Remove config update from subscription filter #10440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
added a commit
that referenced
this pull request
May 15, 2020
(cherry picked from commit ef4ab4a)
kburtram
pushed a commit
that referenced
this pull request
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10438
Not exactly sure why this has just recently started appearing - my best initial guess though is that the Tree used to display the Azure accounts was updated in a recent VS Code merge to cause these to be surfaced. This code has always been broken as far as I can tell from its original implementation (we never were setting the config) and the error itself is also nothing new.
We might want to relook at how we're storing this since currently it's tied to the workspace - but this fix at least gets rid of the error and isn't going to change any existing behavior.