Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pwa-chrome for attach to azuredatastudio #10414

Merged
merged 2 commits into from
May 14, 2020
Merged

Add pwa-chrome for attach to azuredatastudio #10414

merged 2 commits into from
May 14, 2020

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented May 14, 2020

pwa-chrome is better, nuff said.

@aaomidi aaomidi requested a review from anthonydresser May 14, 2020 22:40
anthonydresser
anthonydresser reviewed May 14, 2020
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
anthonydresser
anthonydresser approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@anthonydresser anthonydresser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When are they going to add a DOM explorer to vscode

@aaomidi aaomidi merged commit aea772d into master May 14, 2020
@aaomidi aaomidi deleted the amir/vscodeLaunch/pwaChrome branch May 14, 2020 22:51
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 33.959% when pulling 7def68f on amir/vscodeLaunch/pwaChrome into abdd9af on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydresser anthonydresser anthonydresser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaomidi @coveralls @anthonydresser