Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show empty dropdown when no data sources #10404

Merged
merged 1 commit into from
May 14, 2020

Conversation

kisantia
Copy link
Contributor

Update deploy dialog to show "No data sources in this project" instead of an empty dropdown when there aren't any data sources in the project
image

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 33.954% when pulling dedbf0b on kisantia/deployNoDataSources into 0258b17 on master.

Copy link
Contributor

@Benjin Benjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also disable the generate/deploy buttons if the datasource radio button is selected but there aren't any datasources?

@kisantia
Copy link
Contributor Author

@Benjin yup, like in the screenshot, the generate script and deploy buttons are disabled if the data source radio button is selected but there aren't any data sources

@kisantia kisantia merged commit abdd9af into master May 14, 2020
@kisantia kisantia deleted the kisantia/deployNoDataSources branch May 14, 2020 21:31
@Benjin
Copy link
Contributor

Benjin commented May 14, 2020

@kisantia Oops, totally missed the screenshot! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants