Azure Arc extension #10400
Azure Arc extension #10400
Conversation
bergeron
commented
May 14, 2020
bergeron
commented
- Adds extensions/arc for managing Azure Arc resources.
- Only the Postgres resource is in this PR. SQL will come next.
- Overview, connection strings, and properties pages implemented.
- The UI is built with a ModelViewDashboard.
- Communication with the Arc data controller is done via typescript clients and models generated from the controller's swagger specification.
- See extensions/arc/src/controller/README.md
- I know GitHub makes large PRs hard to read, so let me know if I can make this easier by splitting it up (e.g. removing the generated clients)
…into brberger/arc-postgres
…into brberger/arc-postgres
…into brberger/arc-postgres
…into brberger/arc-postgres
(cherry picked from commit 3ceed3e)
…into brberger/arc-postgres
…into brberger/arc-postgres
…into brberger/arc-postgres
…azuredatastudio into brberger/arc-postgres
…into brberger/arc-postgres
…into brberger/arc-postgres
…into brberger/arc-postgres
bergeron
requested review from
kburtram,
anthonydresser,
alanrenmsft and
Charles-Gagnon
There was a problem hiding this comment.
Add this extension to the list here too
https://github.com/microsoft/azuredatastudio/blob/master/build/lib/extensions.ts#L229
extensions/arc/src/ui/dashboards/postgres/postgresOverviewPage.ts
Outdated
Show resolved
Hide resolved
…into brberger/arc-postgres
The build is failing because of a merge conflict in that file. But I'm confused because I can't reproduce any conflict. This PR doesn't report a conflict, and I don't get a conflict when I merge my branch into master on the command line. |
build/gulpfile.hygiene.js
Outdated
| @@ -109,7 +109,8 @@ const indentationFilter = [ | |||
| '!extensions/sql-database-projects/src/test/baselines/*.sqlproj', | |||
| '!extensions/big-data-cluster/src/bigDataCluster/controller/apiGenerated.ts', | |||
| '!extensions/big-data-cluster/src/bigDataCluster/controller/clusterApiGenerated2.ts', | |||
| '!resources/linux/snap/electron-launch' | |||
| '!resources/linux/snap/electron-launch', | |||
There was a problem hiding this comment.
You can't add stuff here to the bottom of the list, you need to add it to the middle of the list or you'll get conflicts like this.
There was a problem hiding this comment.
Well that's weird. Why? Is the distro merge adding stuff onto the end that it's conflicting with or something?
There was a problem hiding this comment.
Yeah the distro has stuff at the end of this. There's a cleanup we can do there to make sure this stops conflicting.
@anthonydresser do you think we can make a new array in distro and append it programmatically to this array? I've seen this issue come up a bunch of times now.
| } | ||
|
|
||
| protected async registerTabs(modelView: azdata.ModelView): Promise<(azdata.DashboardTab | azdata.DashboardTabGroup)[]> { | ||
| await Promise.all([this._controllerModel.refresh(), this._databaseModel.refresh()]); |
There was a problem hiding this comment.
We'll want to change this before we ship so that there's some indication that it's in a loading state - otherwise it might just be sitting there on an empty blank page for a while if the controller is slow to respond.
