use listdatabases for sqlondemand #10398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanrenmsft
requested review from
Charles-Gagnon,
kisantia,
udeeshagautam and
BranislavGrbicMDCS
src/sql/workbench/contrib/dashboard/browser/widgets/explorer/explorerWidget.component.ts
Outdated
Show resolved
Hide resolved
Charles-Gagnon
approved these changes
May 14, 2020
src/sql/workbench/contrib/dashboard/browser/widgets/explorer/explorerWidget.component.ts
Outdated
Show resolved
Hide resolved
kisantia
approved these changes
May 14, 2020
alanrenmsft
added a commit
that referenced
this pull request
May 14, 2020
* use listdatabases for sqlondemand * comments * use enum
udeeshagautam
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #10397
root cause: SQL on demand servers do not have the views that we need to get the database size and the request will fail
fix: ideally the fix should be made in SQL tools service, i just checked that the STS version in master branch is already higher than the one in release 1.18 branch, to reduce the risk, i am implementing the changes in ADS as a workaround for now and will make proper fix in STS and remove this workaround.
connection service's listdatabases() and the method we use to get databases in this widget are both calling the same request with different parameters, so for now i am using the listdatabases which will only return the database names for sql on demand edition.