Fix a memory leak on listener #10294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sql/workbench/services/objectExplorer/browser/dragAndDropController.ts
Show resolved
Hide resolved
Charles-Gagnon
approved these changes
May 7, 2020
added 2 commits
May 7, 2020 13:38
|
I have a hunch that the test itself was incorrect here, but I'm not entirely sure. If anyone is familiar with this space, please take a look at the changes I've made to the tests. |
Charles-Gagnon
requested changes
May 7, 2020
| @@ -603,7 +603,7 @@ suite('ConnectionConfig', () => { | |||
| providerName: 'MSSQL', | |||
| options: {}, | |||
| saveProfile: true, | |||
| id: 'server3', | |||
| id: 'server3-2', | |||
There was a problem hiding this comment.
I'm not sure this is correct? The ids should be different but currently your update changes them to both be the same.
What was the error you were seeing?
There was a problem hiding this comment.
Well, the tests were failing since this wasn't throwing.
Before, instead of comparing the IDs we were comparing the getConnectionInfoId(), which is somewhat different.
Hmm. I'll see if I can do this without converting to a ConnectionProfile
|
The PR validation failure is because github had a short downtime. |
Charles-Gagnon
approved these changes
May 7, 2020
Charles-Gagnon
approved these changes
May 7, 2020
ktech99
pushed a commit
that referenced
this pull request
Aug 23, 2020
* Fix leak * We don't need the full connection profiles for drag drop control * Remove unused code * Change test definition * Change test definition * Change equality check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was ending up creating a new instance of ConnectionProfile, which ended up listening onto an event.
Before this change, if you dragged a server from the OE around ADS you would end up with over 1000 instances of
ProviderConnectionInfowithin a second.I think this is how memoize was meant to be used, please let me know if this isn't how it was meant to be used. If not I can make my own caching table instead.