Notebook main toolbar additions #10271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y can be implemented with a boolean set to T of F and show labels or shift them into tooltip for accessibility. Updated styles for select boxes. Added toolbar icons to common icon location. Split icon definition for use as masked or background-image.
…into harankin-notebook-ui-toolbar
… theme colors. Simplified icon behavior styles.
…select box border and dropdown arrow. Experimenting with adding masked icon to pseudo element so I can pull out label text from icons.
…into harankin-notebook-ui-toolbar
…side button text. Added icons using this method to respect the color theming system.
…Implemented Underline action. Added custom --wip-- ButtonMenu control, a modified copy of DropDown.
…ed code from new custom control: buttonMneu. Revised icon styles to create a dropdown arrow for buttonMenu.
…ctionViewItem constructor.
chlafreniere
requested review from
corivera,
alanrenmsft,
barbaravaldez and
MaddyDev
chlafreniere
reviewed
May 6, 2020
Charles-Gagnon
requested changes
May 6, 2020
There was a problem hiding this comment.
Could you please include some screenshots showing this new behavior as well? We already have a number of dropdown implementations so I'm not sure we need another new one vs just extending an existing one to support the new functionality you need.
(and if you could outline what functionality you needed that wasn't supported that'd be helpful too)
src/sql/workbench/contrib/notebook/browser/notebook.component.ts
Outdated
Show resolved
Hide resolved
…he class needs. Corrected style declaration for overriding input box padding. Removed unused notebook color styles. Scoped element styles to the toolbar so others outside the toolbar are not affected.
Charles-Gagnon
requested changes
May 7, 2020
…ves some conditionals and CSS classes.
Charles-Gagnon
requested changes
May 8, 2020
src/sql/workbench/contrib/notebook/browser/notebook.component.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/notebook/browser/notebook.component.ts
Outdated
Show resolved
Hide resolved
… notebook toolbar icon spacing. Modified notebook.component contributed actions so that the label text is shifted into the title attribute. Added new icon for Not Trusted toggle.
…into harankin-notebook-ui-toolbar
…into harankin-notebook-ui-toolbar
Charles-Gagnon
requested changes
May 14, 2020
| return new LabeledMenuItemActionItem(action, this.keybindingService, this.contextMenuService, this.notificationService, 'notebook-button'); | ||
|
|
||
| if (action.item.id.includes('jupyter.cmd') && this.previewFeaturesEnabled) { | ||
| incomingLabel = action.label; |
There was a problem hiding this comment.
Remove the incomingLabel and just flip the two below statements
action.tooltip = action.label;
action.label = '';
There was a problem hiding this comment.
Flipped (╯°□°)╯︵ ┻━┻
…d CSS accordingly. Removed unnecessary instance of in-preview class. Fixed code logic that assigns label text to tooltip on incoming contributed action
Charles-Gagnon
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes # (no task assigned)
This PR adds new functionality:
Notebook main toolbar - Created new custom control named:
buttonMenu, which includesDropdownMenuActionViewItem-- which is implemented in the dropdown action at the notebook component level. This displays a dropdown at the first item "+ Cell" when user clicks on it. This allows one to add a new cell as code or as markdown.Lastly, the three actions -- expand/collapse cells, clear contents, and trusted/not-trusted were modified to allow one of two presentations: show label beside icon (current behavior in prod code), or suppress label and add label text to icon tooltip for accessibility (new behavior).
Markdown editor toolbar - Added Underline.
More details:
First item used to add cell as code or markdown:
Add cell menu open:
The end goal here will be use styled elements to replace the OS rendered open menu for this item and all other Notebook UI that opens a menu.
As for functionality:
Here's a snap fo the comp:
