Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 1.17.1 #10224

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Changelog for 1.17.1 #10224

merged 1 commit into from
Apr 30, 2020

Conversation

kburtram
Copy link
Member

Changelog for 1.17.1

@kburtram kburtram requested a review from aaomidi April 30, 2020 01:32
@github-actions
Copy link

Coverage Status

Coverage decreased (-0.005%) to 32.655% when pulling 1522442 on feat/changelog1_17_1 into 87e5239 on master.

## Version 1.17.1
* Release date: April 29, 2020
* Release status: General Availability
* Hotfix for https://github.com/microsoft/azuredatastudio/milestone/54?closed=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is standard on how we do it? I was thinking of linking back to the specific issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how vs code does it too - makes sense to me (that way we don't have to think about whether there's going to be multiple issues or not. We just always do the same thing)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, in this case linking to the issue would make sense, but I tend to agree with @Charles-Gagnon here to just consistently link to the milestone so we can cut\paste these hotfix notes.

@kburtram kburtram merged commit fdc21bf into master Apr 30, 2020
@kburtram kburtram deleted the feat/changelog1_17_1 branch April 30, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants