Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML - dashboard icons and links #10153

Merged
merged 20 commits into from
Apr 29, 2020
Merged

ML - dashboard icons and links #10153

merged 20 commits into from
Apr 29, 2020

Conversation

llali
Copy link
Member

@llali llali commented Apr 24, 2020 •
edited
Loading

Machine Learning extension dashboard updates:

  • Renamed the extension to "Machine Learning"
  • Modified some icons( still waiting for some icons)
  • Added finalized links

image

Charles-Gagnon
Charles-Gagnon reviewed Apr 24, 2020
View reviewed changes
extensions/machine-learning-services/package.json
@@ -1,5 +1,5 @@
{
"name": "machine-learning-services",
"name": "machine-learning",
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon Apr 24, 2020 •
edited by llali
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the folder name too if you're going to be changing this #Resolved

Copy link
Contributor

@alanrenmsft alanrenmsft Apr 24, 2020 •
edited by llali
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the scripts #Resolved

Copy link
Member Author

@llali llali Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the folder and everything build locally but failing in the lab. I'm not sure why. any ideas? #Resolved

@alanrenmsft
Copy link
Contributor

alanrenmsft commented Apr 24, 2020 •
edited by llali
Loading

could you please share a screenshot? #Resolved

@llali llali marked this pull request as ready for review April 27, 2020 20:45
@github-actions
Copy link

github-actions bot commented Apr 27, 2020 •
edited by llali
Loading

Coverage Status

Coverage increased (+0.1%) to 32.658% when pulling 21196d8 on llali/ml_dashboard_icons into 4a87a12 on master.
#Resolved

@llali llali requested review from Benjin and udeeshagautam April 27, 2020 21:41
Charles-Gagnon
Charles-Gagnon approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine - make sure you merge in the changes from master once the cachesalt changes are merged in to verify updating the cachesalt works as expected.

@llali llali merged commit 04af41c into master Apr 29, 2020
@llali llali deleted the llali/ml_dashboard_icons branch April 29, 2020 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanrenmsft alanrenmsft alanrenmsft left review comments

@anthonydresser anthonydresser anthonydresser left review comments

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@Benjin Benjin Awaiting requested review from Benjin

@udeeshagautam udeeshagautam Awaiting requested review from udeeshagautam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llali @alanrenmsft @anthonydresser @Charles-Gagnon