Skip to content

Anchor / cross reference is not scrolling to the appropriate section of Notebook #13899

Closed
@MsSQLGirl

Description

  • Azure Data Studio Version:
    Version: 1.26.0-insider (user setup)
    Commit: 30054e6
    Date: 2020-12-30T06:36:16.231Z
    VS Code: 1.48.0
    Electron: 9.3.0
    Chrome: 83.0.4103.122
    Node.js: 12.14.1
    V8: 8.3.110.13-electron.0
    OS: Windows_NT x64 10.0.19042

Steps to Reproduce:

  1. Open https://raw.githubusercontent.com/MsSQLGirl/jubilant-data-wizards/main/Notebook%20Templates/TroubleshootingGuideTemplate.ipynb in ADS.
  2. Try browsing to the notebook parts using the links, i.e.
    image

Expected:
Users should be able to easily see that the page has scrolled to the target heading / anchor.
For example:
When the ADS Window is maximized:

  1. Actual: When users click on "Overview" (because it's visible on the very bottom of the page), users might not realize / easily find where the link goes to. Suggestion: it would be nice to scroll it to the appropriate heading.
  2. Actual: When users click on "Risk / Impacts", "Symptoms" or "Mitigation", the page scrolls but the headings are not visible. i.e. scrolled too much that users might find hard to identify which section is referring to the link clicked.
    AnchorIssueFullScreen

When the ADS Window is in a custom size (i.e. not maximized), the experience is different from when the window is maximized.

  1. Actual: When users click on "Overview" (not visible on the window, it doesn't go anywhere.
  2. Actual: When users click on "Symptoms", the page scrolls but the Symptoms is right in the middle of the window.
    AnchorIssue

I commented a potentially related issue #9941 (comment) - where the offset issue is more severe if the text cell containing the links are somewhere in the middle of a notebook.

File to repro: https://github.com/MsSQLGirl/jubilant-data-wizards/blob/main/Simple%20Demo/Sample%20Notebooks%20-%20Data%20Analysis/ADSNotebooksDemo.ipynb

In Azure Data Studio, you can simply press Ctrl + O, and paste the raw path
https://raw.githubusercontent.com/MsSQLGirl/jubilant-data-wizards/main/Simple%20Demo/Sample%20Notebooks%20-%20Data%20Analysis/ADSNotebooksDemo.ipynb

(in case the below gif doesn't play, click on it)
LinkingIssue

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions