Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8 installcredprovider scripts #524

Merged
merged 3 commits into from
Oct 10, 2024
Merged

.NET 8 installcredprovider scripts #524

merged 3 commits into from
Oct 10, 2024

Conversation

cobya
Copy link
Contributor

@cobya cobya commented Oct 9, 2024

Add support for the new .NET 8 and .NET Framework 4.8.1 versions in the installcredprovider command line scripts.

Invoke using the $InstallNet8 or $AddNetfx48 switch parameters for the installcredprovider.ps1 script, or USE_NET8_ARTIFACTS_CREDENTIAL_PROVIDER for installcredprovider.sh

@cobya cobya added the enhancement New feature or request label Oct 9, 2024
Copy link
Contributor

@embetten embetten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@cobya cobya merged commit 2a2891c into master Oct 10, 2024
2 checks passed
@cobya cobya deleted the cobya/Net8Install branch October 10, 2024 20:13
cobya added a commit that referenced this pull request Oct 10, 2024
@Cpcrook
Copy link

Cpcrook commented Oct 10, 2024

@cobya I'm seeing some issues a pipeline that utilizes this script since this got merged:

image

Edit: nevermind, looks like you got it reverted before I added my comment

cobya added a commit that referenced this pull request Oct 10, 2024
Missed this commit in #524, adding it back now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants