-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed Identity and Service Principal Support #492
Conversation
CredentialProvider.Microsoft.Tests/CredentialProvider.Microsoft.Tests.csproj
Outdated
Show resolved
Hide resolved
CredentialProvider.Microsoft/CredentialProviders/Vsts/IAuthUtil.cs
Outdated
Show resolved
Hide resolved
CredentialProvider.Microsoft/CredentialProviders/Vsts/VstsCredentialProvider.cs
Outdated
Show resolved
Hide resolved
...tialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskServiceEndpointCredentialProvider.cs
Outdated
Show resolved
Hide resolved
CredentialProvider.Microsoft/Util/FeedEndpointCredentialsParser.cs
Outdated
Show resolved
Hide resolved
CredentialProvider.Microsoft/Util/FeedEndpointCredentialsParser.cs
Outdated
Show resolved
Hide resolved
CredentialProvider.Microsoft/Util/FeedEndpointCredentialsParser.cs
Outdated
Show resolved
Hide resolved
CredentialProvider.Microsoft/CredentialProviders/Vsts/VstsBuildTaskMsalTokenProvidersFactory.cs
Outdated
Show resolved
Hide resolved
...t/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs
Outdated
Show resolved
Hide resolved
same for all new (non test?) files In reply to: 2116411091 Refers to: CredentialProvider.Microsoft/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs:1 in 0dceaff. [](commit_id = 0dceaff, deletion_comment = False) |
test files too In reply to: 2116411506 Refers to: CredentialProvider.Microsoft/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs:1 in 0dceaff. [](commit_id = 0dceaff, deletion_comment = False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the build warnings as well, there are a few about package conflicts. surprised these are not failing the build :( |
Overview
ARTIFACTS_CREDENTIALPROVIDER_FEED_ENDPOINTS
environment variable with new json schema for MI/SP required fields.VSS_NUGET_EXTERNAL_FEED_ENDPOINTS
environment variable.Design Decisions
VSS_NUGET_EXTERNAL_FEED_ENDPOINTS
to reduce password usage and clarify the environment variable will be available to our other credproviders such as the artifacs-keyring not just NuGet.Environment Variable
ARTIFACTS_CREDENTIALPROVIDER_FEED_ENDPOINTS
endpoint
: required. Feed url to authenticate against.clientId
: required for both MI/SP. For user assigned managed identities enter the Entra client id. For system assigned variables set the value tosystem
.clientCertificateSubjectName
: Subject Name of the certificate located in the My/ CurrentUser or LocalMachine certificate store. Optional field. Only used by SP authentication.clientCertificateFilePath
: File path location of the certificate on the machine. Optional field. Only used by SP authentication.Will throw error if both
clientCertificateSubjectName
orclientCertificateFilePath
are specified.