Changed install script to make it compatible for sh on linux #457
Conversation
|
Works with default options, but if I set AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION then I get errors: export AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION=v1.1.0-alpha
sh -c "$(curl -fsSL https://raw.githubusercontent.com/microsoft/artifacts-credprovider/ba93b5218249ec3792470f9b2f48c91bd930a016/helpers/installcredprovider.sh)"still gives me an error |
|
If we're making this work for environments without bash, should we also update the file's shebang? |
Is our posture to support the lowest common denominator? |
|
The issue customers faced is that on some environments, the customer had to first install bash before they could get the cred provider installed. The installation script should work whether bash is available or not. |
helpers/installcredprovider.sh
Outdated
| if [ ! -z ${AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION} ] && [ ${AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION} == 0.* ] || [ "$AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION" = "v0.*" ]; then | ||
| echo "ERROR: To install NET6 cred provider using the USE_NET6_ARTIFACTS_CREDENTIAL_PROVIDER variable, version to be installed must be 1.0.0. or greater. Check your AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION variable." | ||
| exit 1 | ||
| if [ ! -z ${AZURE_ARTIFACTS_CREDENTIAL_PROVIDER_VERSION} ]; then |
There was a problem hiding this comment.
you should be able to remove this entirely, as if it's null it will just drop through the case
The PR changes the syntax of the credprovider install script to make it compatible with shell.
Fixes bug #2100273 and this bug #450