Upgrade to check-spelling 0.0.20alpha7 #19127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Config based on: https://github.com/check-spelling/spell-check-this/tree/a5001170a754da309ca324ce7eed8a076af2f4ac * Adding duplicate detection to patterns.txt * Adding line_forbidden.patterns * Adding reject.txt * Updated excludes (and sorted) * Switching to unified workflow * moving `wil` to allow.txt to clarify that it's a term of art (https://github.com/microsoft/wil), whereas often it's a typo for `will`.
jsoref
commented
Jul 1, 2022
There was a problem hiding this comment.
The forbidden items flagged here shouldn't appear once the PR merges, as they aren't present here:
https://github.com/jsoref/PowerToys/runs/7140523891?check_suite_focus=true
I'm not quite certain why the 0.0.20alpha3 version is complaining about the patterns.
| * When you add new strings make sure you have add add all translations for it. | ||
| * When you add new strings make sure you have added all translations for it. |
There was a problem hiding this comment.
This is notable in that it isn't the obvious change
| /// The time stamp stamp for this message, equivalent to what GetMessageTime would return for this message. | ||
| /// The time stamp for this message, equivalent to what GetMessageTime would return for this message. |
There was a problem hiding this comment.
I'm on the fence on what change to make here, e.g. using timestamp.
| public void DedupFunctionWhenCalledMustNotRemovelnkWhichdoesNotHaveExe() | ||
| public void DedupFunctionWhenCalledMustNotRemovelnkWhichDoesNotHaveExe() |
There was a problem hiding this comment.
I'm pretty sure this is an auto thing, and there didn't seem to be any reason not to do:
-Whichdoes
+WhichDoes
Comment on lines
-29
to
+31
| public string GithubRepo { | ||
| public string GitHubRepo { | ||
| get { | ||
| return ((string)(this["GithubRepo"])); | ||
| return ((string)(this["GitHubRepo"])); |
There was a problem hiding this comment.
This commit is probably the most notable.
Jay-o-Way
added
the
Area-GitHub workflow
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jaimecbernardo
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
line_forbidden.patterns) -- you can see a number of examples in this PRpre-existing,MicroSoft, andGithub) -- this complained aboutGithub-- if this is a problem, that item can be removed fromline_forbidden.patternsreject.txt) -- this caughtwetherwhich is an archaic word that was originally reported by the terminal folkswiltoallow.txt(which is a way to add items to the dictionary -- the opposite ofreject.txt)PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed