RunSamples.cmd should signal failure if non-zero RC from sparkclr-submit script #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RunSamples.cmd should signal runtime failure if non-zero RC from underlying call to sparkclr-submit.cmd script. [The final `popd` was previously masking this value.] - Fix non-standard usage of quotes between RunSamples.cmd and PreCheck.cmd scripts. - Print directory location info for strategic pushd's
jthelin
force-pushed
the
RunSamples-Fail-If-Error
branch
from
834bdad to
7159d91
Compare
|
Rebased against master HEAD 30ff79d |
|
will merge this change after today's release and version upgrade |
|
Closing the PR for now as it competes with CI for other changes going in for the release. Will reopen after the release. |
|
No worries. Not urgent :) |
|
restarted AppVeyor build. |
Current coverage is
|
|
LGTM |
danielli90
added a commit
that referenced
this pull request
Jan 15, 2016
RunSamples.cmd should signal failure if non-zero RC from sparkclr-submit script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweak to
RunSamples.cmdscript makes it easier to detect any problems in the build environment, because build agent [eg VSO] will detect non-zero exit code which was previously being masked by extra commands at end of script.RunSamples.cmdshould signal runtime failure if non-zero RC from underlying call tosparkclr-submit.cmdscript. [The finalpopdwas previously masking this value.]Should have no affect on the core team's Appveyor build, but my private VSO build was not detecting / marking build failures when it should have been due to some test config issues.