Change functions in common.h into template functions (#969) #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function names must be in the "Pascal Case" style. * check_elements_interval_closed to CheckElementsIntervalClosed * obtain_min_max_sum to ObtainMinMaxSum
* CheckElementsIntervalClosed * ObtainMinMaxSum These two functions were changed into template functions.
guolinke
reviewed
Oct 7, 2017
include/LightGBM/utils/common.h
Outdated
| @@ -604,6 +610,11 @@ inline void ObtainMinMaxSum(const float *w, int nw, float *mi, float *ma, double | |||
| if (su != nullptr) *su = sumw; | |||
| } | |||
|
|
|||
| template <typename T> | |||
| inline void ObtainMinMaxSum(const T *w, int nw, T *mi, std::nullptr_t, double *su) { | |||
There was a problem hiding this comment.
su could be T2 type.
I prefer to remove this function, and using ObtainMinMaxSum<float, double>(w, nw, mi, (float*)nullptr, su) to call the function.
* remove an overload of the function ObtainMinMaxSum
guolinke
previously approved these changes
Oct 8, 2017
guolinke
reviewed
Oct 8, 2017
include/LightGBM/utils/common.h
Outdated
| for (int i = 0; i < ny; ++i) { | ||
| if (y[i] < ymin || y[i] > ymax) { | ||
| Log::Fatal("[%s]: does not tolerate element [#%i = %f] outside [%f, %f]", callername, i, y[i], ymin, ymax); | ||
| if (typeid(T) == typeid(float) || typeid(T) == typeid(double)) { |
There was a problem hiding this comment.
why this ? for the format output ?
you can use the stringstream to format T type.
guolinke
approved these changes
Oct 8, 2017
guolinke
pushed a commit
that referenced
this pull request
Oct 9, 2017
* Fix coding style (#969) Function names must be in the "Pascal Case" style. * check_elements_interval_closed to CheckElementsIntervalClosed * obtain_min_max_sum to ObtainMinMaxSum * Change functions in common.h into template functions (#969) * CheckElementsIntervalClosed * ObtainMinMaxSum These two functions were changed into template functions. * Remove an unpreferable overload * remove an overload of the function ObtainMinMaxSum * Use stringstream to format T type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckElementsIntervalClosed
ObtainMinMaxSum
These two functions were changed into template functions.