-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUDA] Add Poisson regression objective for cuda_exp and refactor objective functions for cuda_exp #5486
Conversation
update log in test_register_logger
…oft/LightGBM into cuda/objective-regression
add test cases for regression objectives
…oft/LightGBM into cuda/objective-regression
@shiyu1994 now that recent CI issues have been addressed, I just pushed 29d5735 updating this with |
The self-hosted CUDA machine has a driver issue again. Reboot the machine and reopen this PR. |
@shiyu1994 ping me when this PR is ready |
@guolinke Some segment faults are failing. Will fix them soon. BTW, this PR refactors the cuda objective classes into a more elegant format. So it does not only add an objective and there will be more code changes. |
@shiyu1994 I'm seeing those same segfaults on the I've been trying different things on #5588 and so far haven't been able to fix it 😭 . |
@shiyu1994 I just updated this to latest |
Close and reopen to trigger ci test. |
@jameslamb Thanks for your help! |
…oft/LightGBM into cuda/objective-regression
@guolinke This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Add Poisson regression objective for cuda_exp. We noticed that for Poisson regression, the results of
test_regression
intest_engine.py
is slightly worse than CPU version. We conjecture there's still minor difference between details ofcuda_exp
andcpu
. We will record it in an issue for now and fix the gap later on.