Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Add Poisson regression objective for cuda_exp and refactor objective functions for cuda_exp #5486

Merged
merged 49 commits into from
Nov 27, 2022

Conversation

shiyu1994
Copy link
Collaborator

Add Poisson regression objective for cuda_exp. We noticed that for Poisson regression, the results of test_regression in test_engine.py is slightly worse than CPU version. We conjecture there's still minor difference between details of cuda_exp and cpu. We will record it in an issue for now and fix the gap later on.

update log in test_register_logger
add test cases for regression objectives
@jameslamb
Copy link
Collaborator

@shiyu1994 now that recent CI issues have been addressed, I just pushed 29d5735 updating this with master for you 👋

@shiyu1994
Copy link
Collaborator Author

The self-hosted CUDA machine has a driver issue again. Reboot the machine and reopen this PR.

@shiyu1994 shiyu1994 closed this Nov 11, 2022
@shiyu1994 shiyu1994 reopened this Nov 11, 2022
@guolinke
Copy link
Collaborator

@shiyu1994 ping me when this PR is ready

@shiyu1994
Copy link
Collaborator Author

@guolinke Some segment faults are failing. Will fix them soon. BTW, this PR refactors the cuda objective classes into a more elegant format. So it does not only add an objective and there will be more code changes.

@jameslamb
Copy link
Collaborator

@shiyu1994 I'm seeing those same segfaults on the Linux_ jobs over on #5588. I don't think they're related to the code in this PR.

I've been trying different things on #5588 and so far haven't been able to fix it 😭 .

@jameslamb
Copy link
Collaborator

@shiyu1994 I just updated this to latest master. Now that #5580 has been merged, hopefully you won't see other CI issues.

@shiyu1994
Copy link
Collaborator Author

Close and reopen to trigger ci test.

@shiyu1994 shiyu1994 closed this Nov 25, 2022
@shiyu1994 shiyu1994 reopened this Nov 25, 2022
@shiyu1994
Copy link
Collaborator Author

@jameslamb Thanks for your help!

@shiyu1994
Copy link
Collaborator Author

@guolinke This is ready for review.

Copy link
Collaborator

@guolinke guolinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiyu1994 shiyu1994 merged commit 24af9fa into master Nov 27, 2022
@shiyu1994 shiyu1994 deleted the cuda/objective-regression branch November 27, 2022 14:09
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants