Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove examples/.gitignore #4486

Merged
merged 1 commit into from
Jul 24, 2021
Merged

remove examples/.gitignore #4486

merged 1 commit into from
Jul 24, 2021

Conversation

jameslamb
Copy link
Collaborator

Working on #4485, I was looking at the CLI examples in https://github.com/microsoft/LightGBM/tree/master/examples tonight and noticed there is a .gitignore left there (unmodified since October 2016, 351b3d7).

This PR proposes removing it. As of this PR, the single root-level .gitignore would be the only place managing ignoring files in source control, which I think is a bit easier to maintain and reason about.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice catch!

@StrikerRUS StrikerRUS merged commit 5d40dc4 into master Jul 24, 2021
@StrikerRUS StrikerRUS deleted the misc/remove-gitignore branch July 24, 2021 12:55
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants