Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] add missing JNI exception checks to fix warnings #2405

Merged
merged 4 commits into from
Sep 26, 2019
Merged

[Java] add missing JNI exception checks to fix warnings #2405

merged 4 commits into from
Sep 26, 2019

Conversation

imatiach-msft
Copy link
Contributor

fixes the warnings as described in #2360
by @chris-smith-zocdoc
FYI @eisber

@imatiach-msft imatiach-msft changed the title add missing JNI exception checks to fix warnings [Java] add missing JNI exception checks to fix warnings Sep 13, 2019
@imatiach-msft imatiach-msft mentioned this pull request Sep 13, 2019
Closed
@StrikerRUS StrikerRUS requested a review from guolinke September 13, 2019 11:35
eisber
eisber reviewed Sep 13, 2019
View reviewed changes
swig/lightgbmlib.i Outdated Show resolved Hide resolved
eisber
eisber reviewed Sep 16, 2019
View reviewed changes
swig/lightgbmlib.i Outdated Show resolved Hide resolved
StrikerRUS
StrikerRUS reviewed Sep 16, 2019
View reviewed changes
swig/lightgbmlib.i Outdated Show resolved Hide resolved
@eisber
Copy link
Contributor

eisber commented Sep 17, 2019

looks good to me

@StrikerRUS
Copy link
Collaborator

@guolinke Can we merge this?

@guolinke guolinke merged commit 7b2963d into microsoft:master Sep 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS left review comments

@eisber eisber eisber left review comments

@chris-smith-zocdoc chris-smith-zocdoc chris-smith-zocdoc left review comments

@guolinke guolinke guolinke approved these changes

@mhamilton723 mhamilton723 mhamilton723 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@imatiach-msft @eisber @StrikerRUS @chris-smith-zocdoc @mhamilton723 @guolinke