Refine config object #1381
Refine config object #1381
Conversation
|
@guolinke |
|
@StrikerRUS with the python script, the details of these parameters can be captured. Then we can use to generate documents directly. |
|
@StrikerRUS do you know why test_skearn will pass updated: fixed, due to the name conflict of saved parameters. |
|
@guolinke I tried it locally - cool thing! Should we add a corresponding step on CIs to generate fresh |
|
@guolinke I've gave a brief glance to it and pushed a few things: new Is Some aliases disappeared from alias table: |
|
@guolinke I've added |
src/metric/dcg_calculator.cpp
Outdated
| void DCGCalculator::Init(std::vector<double> input_label_gain) { | ||
|
|
||
| void DCGCalculator::DefaultEvalAt(std::vector<int>* eval_at) { | ||
| if (!eval_at->empty()) { |
There was a problem hiding this comment.
@guolinke I'm not sure, but it seems to be a typo in condition.
|
@StrikerRUS thanks, had fixed them. |
|
@guolinke yeah, after digging into the code I understand your idea! Sure, will write a function which will generate a part of |
include/LightGBM/config.h
Outdated
|
|
||
| // alias=num_classes | ||
| // desc=need to specify this in multi-class classification | ||
| int num_class = 1; |
There was a problem hiding this comment.
Maybe bring it back to the Objective section?
There was a problem hiding this comment.
@guolinke Could you please give a little bit more detailed description of these parameters. We haven't published them before.
include/LightGBM/config.h
Outdated
| bool enable_load_from_binary_file = true; | ||
|
|
||
| // desc=set to false to disable Exclusive Feature Bundling (EFB) | ||
| bool enable_bundle = true; |
include/LightGBM/config.h
Outdated
|
|
||
| // check=>=0 | ||
| // max conflict rate for bundles in EFB | ||
| double max_conflict_rate = 0.0; |
include/LightGBM/config.h
Outdated
|
|
||
| // desc= frequency of saving model file snapshot | ||
| // desc= set to positive numbers will enable this function | ||
| int snapshot_freq = -1; |
|
@StrikerRUS sure, take your time : ) |
|
@StrikerRUS you can approve this PR if you think it is okay to merge first. |
|
Sorry, forgot about it. |
Previous config object is complex for developing and documenting.
With this PR, the changes of parameters can be simply written in
config.h.Then we can use
helper\parameter_generator.pyto generate related codes and documents.I just finish the code generating part.
@StrikerRUS can you help for the doc part ? Thanks very much !
BTW, also fixed #1364