Fix + Tests: Add more tests covering the modules API, fix error handling bug that were found. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `DetoursFindFunction` wasn't gracefully handling NULL function name. - `DetourEnumerateModules` wasn't resetting GLE on success. - `DetourEnumerateExports` wasn't gracefully handling NULL export callback. - `DetourEnumerateImports` wasn't gracefully handling NULL arguments.
bgianfo
added
bug
bgianfo
force-pushed
the
add-more-tests
branch
2 times, most recently
from
9b200f5 to
3bfbe37
Compare
Test basic functionality and error handling of the Detours Module API. * DetourLoadImageHlp * DetourFindFunction * DetourEnumerateModules * DetourEnumerateExports * DetourEnumerateImports * DetourGetSizeOfPayloads * DetourFindPayload * DetourFindPayloadEx * DetourRestoreAfterWithEx
bgianfo
added
the
auto-merge
|
Hello @bgianfo! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
bgianfo
added
auto-merge
dtarditi
approved these changes
Mar 5, 2021
bgianfo
added
the
auto-merge
|
Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request. |
number201724
pushed a commit
to number201724/Detours
that referenced
this pull request
Mar 5, 2021
…ing bug that were found. (microsoft#177) * Fix: Handle more error cases in module API. - `DetoursFindFunction` wasn't gracefully handling NULL function name. - `DetourEnumerateModules` wasn't resetting GLE on success. - `DetourEnumerateExports` wasn't gracefully handling NULL export callback. - `DetourEnumerateImports` wasn't gracefully handling NULL arguments. * Tests: Add more tests covering the modules API. Test basic functionality and error handling of the Detours Module API. * DetourLoadImageHlp * DetourFindFunction * DetourEnumerateModules * DetourEnumerateExports * DetourEnumerateImports * DetourGetSizeOfPayloads * DetourFindPayload * DetourFindPayloadEx * DetourRestoreAfterWithEx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add more tests for the basic functionality and error handling of the Detours Module API.
DetourLoadImageHlpDetourFindFunctionDetourEnumerateModulesDetourEnumerateExportsDetourEnumerateImportsDetourGetSizeOfPayloadsDetourFindPayloadDetourFindPayloadExDetourRestoreAfterWithExIt also fixes some error handling issues that the tests found in the module API.
DetoursFindFunctionwasn't gracefully handling NULL function name.DetourEnumerateModuleswasn't resetting GLE on success.DetourEnumerateExportswasn't gracefully handling NULL export callback.DetourEnumerateImportswasn't gracefully handling NULL arguments.Microsoft Reviewers: Open in CodeFlow