Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files in fp_quantize op from quantize.* to fp_quantize.* #5577

Merged
merged 3 commits into from
May 28, 2024

Conversation

loadams
Copy link
Contributor

@loadams loadams commented May 28, 2024

Fixes #5535.

Todo: need to test.

@loadams
Copy link
Contributor Author

loadams commented May 28, 2024

Tagging @jeffra to review?

@jeffra
Copy link
Collaborator

jeffra commented May 28, 2024

It seems I don't have permission to review, but consider this me approving haha :) @RezaYazdaniAminabadi also took a look and looks fine to him as well.

@tjruwase
Copy link
Contributor

@jeffra and @RezaYazdaniAminabadi thanks for the review!

@tjruwase tjruwase added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit bf66acd May 28, 2024
12 checks passed
sfc-gh-reyazda pushed a commit to Snowflake-Labs/DeepSpeed that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] fp_quantizer is not correctly built when non-jit installation
3 participants