Re-organize .gitignore file to be parsed properly
#4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file was re-organized in da652d0[^1] with better documentation, but that unfortunately made the syntax invalid. According to the gitignore documentation:[^2] > A line starting with # serves as a comment. Put a backslash ("`\`") in > front of the first hash for patterns that begin with a hash. I needed to move the comments for Git to parse the file properly. To maintain readability, I added an extra `#` to the comments at the top of each section. [^1]: microsoft@da652d0 [^2]: https://git-scm.com/docs/gitignore/2.43.0#_pattern_format
loadams
approved these changes
Nov 28, 2023
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
The file was re-organized in da652d0[^1] with better documentation, but that unfortunately made the syntax invalid. According to the gitignore documentation:[^2] > A line starting with # serves as a comment. Put a backslash ("`\`") in > front of the first hash for patterns that begin with a hash. I needed to move the comments for Git to parse the file properly. To maintain readability, I added an extra `#` to the comments at the top of each section. [^1]: microsoft@da652d0 [^2]: https://git-scm.com/docs/gitignore/2.43.0#_pattern_format Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file was re-organized in da652d01 with better documentation, but that unfortunately made the syntax invalid. According to the gitignore documentation:2
I needed to move the comments for Git to parse the file properly. To maintain readability, I added an extra
#to the comments at the top of each section.Footnotes
https://github.com/microsoft/DeepSpeed/commit/da652d0e0b4ff0b7c870e74730b9d3d8f51bf8aa ↩
https://git-scm.com/docs/gitignore/2.43.0#_pattern_format ↩