Fix missing scale attributes for GPTJ #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmikeh2
requested review from
RezaYazdaniAminabadi,
jeffra,
mrwyattii,
awan-10 and
arashb
as code owners
This was
linked to
issues
Apr 17, 2023
mrwyattii
approved these changes
Apr 20, 2023
jeffra
approved these changes
Apr 21, 2023
conglongli
added
deepspeed-chat
|
@cmikeh2 I'm now using TP=8 with huggingface to inference llama, and I found memory overlap between input and output. I think it is due to the workspace offset? I see it is now 4 * buf_size，but may not be enough for TP=8? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two regressions introduced in the DeepSpeed chat release for GPT-J:
scaleattribute on all parameters before accessing.