add new "morph" and "refresh" action types for turbo-stream, issue #772 #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sdelamo
requested changes
Apr 18, 2024
| * Morph only the children of the element designated by the target dom id. | ||
| */ | ||
| private final boolean childrenOnly; | ||
|
|
||
| @Nullable | ||
| private final Object template; | ||
|
|
||
| TurboStream(@NonNull TurboStreamAction action, |
There was a problem hiding this comment.
keep the old constructor and annotate it with @Deprecated and also add @deprecated javadoc indicating to use the new one.
There was a problem hiding this comment.
good catch, have added it back
sdelamo
approved these changes
Apr 19, 2024
sdelamo
added a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.