Closed
Description
Hi,
I'm not sure if I'm missing something in my implementation, but I would expect that if an OTel span is ended and is yet "unset", it would be set to "ok".
Right now I can see it is always "unset" at the end which is somewhat odd.
But please let me know in case I've missed anything.
Thanks for looking at it in advance.
Activity
jonatan-ivanov commentedon Nov 21, 2024
Thanks for the issue!
Are you interested in creating a PR to fix this?
OtelSpan
has twoend
methods and theerror
method is already setting the status so setting inend
should be straightforward.GFriedrich commentedon Nov 21, 2024
@jonatan-ivanov first of all: Thanks for checking.
Sure, I can create a PR with a fix, but it may take until the weekend.
jonatan-ivanov commentedon Nov 22, 2024
That's totally fine, our next release is in two weeks. I asked since this seems a good issue if one wants to contribute. If you don't or you won't find the time, that's of course 120% fine, just let me know and I'll fix it.
Fix setting OTel status on required situations
GFriedrich commentedon Nov 24, 2024
hey @jonatan-ivanov,
tried to fix the issue and found a few more issues, but let me start from the beginning:
ERROR
and it could overwrite the status then toOK
OtelSpan
, but this would've caused issues when creating the span by wrapping some existing span, as it suffers from the same issue: not knowing the previous statusOK
, you can't change it anymoreReadableSpan
, which then generates the span data to get the statusAdditionally I found the following other problems:
OtelSpan
for no good reasonthis
this
Fix setting OTel status on required situations
Fix setting OTel status on required situations
Fix setting OTel status on required situations
Fix setting OTel status on required situations
5 remaining items