Experimental language parsing #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaronpk @dissolve @barnabywalters and anyone else: if you have time would you mind reviewing this PR? I'd like to get this set of three PRs merged so I can work on further improvements. This is the second of the three. |
|
From my understanding of the brainstorming discussion, the language attribute should only be added to the parsed result if it contains some information. It looks like this PR adds it even when the value is an empty string, which seems wrong. Am I reading this correctly? |
Updated trim() to unicodeTrim().
|
Good point. I fixed that and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #96