added Area tag #58
Merged
added Area tag #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I included a fix for a failing test for capitalization of tags. All tests now pass on my Linux machine. |
|
@dissolve thanks so much for your hard work and patience with this pull request! I have, finally, merged it with only minor code style changes (tabs!). The area parsing code and corresponding tests all look excellent, as do your improvements to the implied u-url parsing. I released your changes under v0.2.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers the addition of area tag and other minor tweaks to the alg.
http://microformats.org/wiki/index.php?title=microformats2-parsing&diff=64687&oldid=64684
also fixes an issue where it was not testing for :not[.h-] at implied properties for url
' else if .h-x>a[href]:only-of-type:not[.h-] then use that [href] for url '