Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing for iframe.u-*[src] #182

Closed
gRegorLove opened this issue Jul 24, 2018 · 0 comments · Fixed by #200
Closed

Fix parsing for iframe.u-*[src] #182

gRegorLove opened this issue Jul 24, 2018 · 0 comments · Fixed by #200
Milestone
0.5.0

Comments

@gRegorLove
Copy link
Member

Per spec update:

<div class="h-entry">
<h1 class="p-name">Title</h1>
<iframe src="https://example.com/index.html" class="u-url">
  <p>Your browser does not support iframes.</p>
</iframe>
</div>

Currently parses:

"items": [
    {
        "type": [
            "h-entry"
        ],
        "properties": {
            "name": [
                "Title"
            ],
            "url": [
                "<p>Your browser does not support iframes.</p>"
            ]
        }
    }
]

Expected:

"items": [
    {
        "type": [
            "h-entry"
        ],
        "properties": {
            "name": [
                "Title"
            ],
            "url": [
                "https://example.com/index.html"
            ]
        }
    }
]
@gRegorLove gRegorLove mentioned this issue Jul 24, 2018
Closed
@gRegorLove gRegorLove added this to the 0.4.4 milestone Aug 1, 2018
@aaronpk aaronpk modified the milestones: 0.4.4, 0.4.5 Aug 1, 2018
@aaronpk aaronpk removed this from the 0.4.6 milestone Aug 24, 2018
@gRegorLove gRegorLove added this to the 0.4.7 milestone Aug 25, 2018
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Aug 25, 2018
@gRegorLove
Add failing test and fix for microformats#182
cef3d61
@gRegorLove gRegorLove mentioned this issue Aug 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Fix parsing for iframe.u-*[src] gRegorLove/php-mf2
2 participants
@aaronpk @gRegorLove