Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow numbers in vendor prefixes #158

Closed
gRegorLove opened this issue Mar 21, 2018 · 1 comment
Closed

Allow numbers in vendor prefixes #158

gRegorLove opened this issue Mar 21, 2018 · 1 comment
Milestone
0.4.2

Comments

@gRegorLove
Copy link
Member

gRegorLove commented Mar 21, 2018 •
edited
Loading

Minimal example from https://aaronparecki.com/2018/03/21/18/

<li class="h-entry">
  <data class="p-name" value="Coffee"></data>
  <div class="p-p3k-drank h-p3k-food">
    <span class="value">Coffee</span>
  </div>
</li>

Currently parses:

    "items": [
        {
            "type": [
                "h-entry"
            ],
            "properties": {
                "name": [
                    "Coffee"
                ]
            }
        }
    ]

Expected output via mf2py dev

    "items": [
        {
            "type": [
                "h-entry"
            ], 
            "properties": {
                "name": [
                    "Coffee"
                ], 
                "p3k-drank": [
                    {
                        "type": [
                            "h-p3k-food"
                        ], 
                        "properties": {
                            "name": [
                                "Coffee"
                            ]
                        }, 
                        "value": "Coffee"
                    }
                ]
            }
        }
    ]

Per spec update: microformats/microformats2-parsing#28
@gRegorLove
Copy link
Member Author

See also: https://github.com/kartikprabhu/mf2py/blob/experimental/test/examples/class_names_format.html

gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Mar 22, 2018
@gRegorLove
Add failing tests and fixes for microformats#158, microformats#160
4787005
@gRegorLove gRegorLove mentioned this issue Mar 22, 2018
Merged
@gRegorLove gRegorLove added this to the 0.4.2 milestone Mar 23, 2018
aaronpk added a commit that referenced this issue Mar 25, 2018
@aaronpk
Merge pull request #161 from gRegorLove/issue158
743d979 
Add failing tests and fixes for #158, #160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
1 participant
@gRegorLove