Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

second mf1 root class is lost #156

Closed
kartikprabhu opened this issue Mar 17, 2018 · 0 comments
Closed

second mf1 root class is lost #156

kartikprabhu opened this issue Mar 17, 2018 · 0 comments
Milestone
0.4.4

Comments

@kartikprabhu
Copy link
Member

When there are multiple mf1 root classes the second one is lost.

Example 1

HTML

<article class="vevent hentry">
    <span class="entry-title">h-entry name</span>
    <span class="summary">h-event name</span>
</article>

Current output

    "items": [
        {
            "type": [
                "h-event"
            ],
            "properties": {
                "name": [
                    "h-entry name",
                    "h-event name"
                ]
            }
        }
    ]

Expected output

    "items": [
        {
            "type": [
                "h-event", 
                "h-entry"
            ], 
            "properties": {
                "name": [
                    "h-entry name", 
                    "h-event name"
                ]
            }
        }
    ]

Example 2

HTML

<article class="hentry vevent">
    <span class="entry-title">h-entry name</span>
    <span class="summary">h-event name</span>
</article>

Current output

    "items": [
        {
            "type": [
                "h-entry"
            ],
            "properties": {
                "name": [
                    "h-entry name",
                    "h-event name"
                ]
            }
        }
    ]

Expected output

    "items": [
        {
            "type": [
                "h-entry",
                "h-event" 
            ], 
            "properties": {
                "name": [
                    "h-entry name", 
                    "h-event name"
                ]
            }
        }
    ]
@gRegorLove gRegorLove added this to the 0.4.3 milestone Mar 25, 2018
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Jul 9, 2018
@gRegorLove
Add failing test and fix for microformats#156
5b188ec
@gRegorLove gRegorLove mentioned this issue Jul 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.4
Development

No branches or pull requests
2 participants
@kartikprabhu @gRegorLove