Add tap tests on pgsodium objects schema #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the tests are currently failing because of #68 |
This fixes errors related to the object schema resolution.
ioguix
force-pushed
the
schema_tests
branch
2 times, most recently
from
8dadb20 to
727e10c
Compare
This makes any change easier to spot
Adding checks for: language, return type, volatility, strictiness, security definer and function kind.
|
Hi, There's currently 1729 tests including the ones from commit f64f2cf. We could add some more tests around indexes & constraints on table From here, I'll need some serious review, the next steps would be to:
Regards, |
ioguix
changed the title
michelp
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
This is huge! Thanks so much for this work. I went through it as much as I could, and I'm happy with "freezing" the interface contract to this test spec going forward. As the package evolves we'll be careful to make sure the contract is honored or making very explicit major version releases that might break things.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tap tests on the pgsodium extension itself. This should help enforce some sanity rules about ownership, privileges, existing objects, etc.
This is currently a draft as:
pgsodium_tapgen.plperl script and needs some detailed review.The generation script itself is included in this PR for information only. The objective is to edit the
pgsodium_schema.sqltest script bu hand.