Improve startup log messages #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm github won't run the tests it says "Expected-- Waiting for status to be reported" that's... unclear. Anyway, googling is giving me vague answers about personal access tokens, any thoughts on what I'm waiting to be reported to from what? |
When the getkey_script file is missing, previous startup error message was wrongly showing "Permission denied for %s". This shows a relevant error message with addition of some details and hints. The patch also improves other startup error/log messages so they repect the PostgreSQL log format if stderr is collected.
ioguix
force-pushed
the
errmsg_pgsodium_getkey
branch
from
b2d2788 to
b75cb3c
Compare
I have absolutely no clue... First time I'm seeing this. I rebased the branch on current HEAD by the way. |
|
Maybe you can somehow manually trigger the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the getkey_script file is missing, previous startup error message was wrongly showing "Permission denied for %s". This shows a relevant error message with addition of some details and hints.
The patch also improves other startup error/log messages so they repect the PostgreSQL log format if stderr is collected.