postinstall: Adding argument parser and further fixes for user install #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of it was needed to run the script directly with Py3. Some other changes were made just because it felt like sand in my eyes..
Gives more control over the options and added checks to prevent wrong input early.
This way we can pass the correct installation location to the postinstall script.
After commiting the previous commit, I just noticed that prefix is not correct. Believe that install_lib should have the correct location to the site-packages directory, where we did our install.
Only one of both is needed.
thopiekar
changed the title
mhammond
requested changes
Aug 27, 2019
Tested it before, but noticed that it the negation was missing.
Without paths with whitespaces won't be found. Found by @mhammond while reviewing mhammond#1396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1391 I managed to fix the user install and replaced the own implementation of an argument parser with argparse. Among that I just added some simple checks to prevent bad input.
However, the CI testing isn't finished and hangs still. Therefore, I'm providing these changes separately, too.
It is recommended to merge these efforts together with #1392 to get full user install support.