Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Adding AppVeyor CI (v2) #1187

Merged
merged 4 commits into from
May 3, 2018

Conversation

thopiekar
Copy link
Contributor

Second version, which includes all work I did before.
It needs fixes and tweaks to some files, like setup.py.
Additionally, it does no real tests at the moment and also does not use the latest SWIG to build the C extensions.

However, at least something that is usable.

Second version, which includes all work I did before.
It needs fixes and tweaks to some files, like setup.py.
Additionally, it does no real tests at the moment and also does not use the latest SWIG to build the C extensions.

However, at least something that is usable.
@thopiekar thopiekar changed the title CI: Adding AppVeyor CI (V2) CI: Adding AppVeyor CI (v2) Mar 29, 2018
There is no such a file anymore. `setup.py` handles both now.

Signed-off-by: Thomas Karl Pietrowski <thopiekar@gmail.com> (github: thopiekar)
@thopiekar
Copy link
Contributor Author

thopiekar commented Apr 30, 2018

#1200 needs to be fixed.

As discussed in an issue report [1], I'm skipping the tests here.
Therefore the only worrying issue is, how to fix the Python 2.7 builds.
But, however, that is a different story.

---------
[1] mhammond#1200
@mhammond
Copy link
Owner

mhammond commented May 3, 2018

Great, thanks - I'll merge this and we can see what the fallout is :)

@mhammond mhammond merged commit b69d0e8 into mhammond:master May 3, 2018
@thopiekar thopiekar deleted the master-add-appveyor-ci-v2 branch May 3, 2018 07:48
@thopiekar
Copy link
Contributor Author

No problem. The only thing, which won't work ever, are Python 2.7 builds. The main reason is that AppVeyor comes with Visual Studio 2008 Express, but only the Standard and Professional edition are providing the needed directory with the MFC90 libraries.

I sent yesterday a mail to the AppVeyor team to ask whether it is possible to upgrade it or not.

There is an alternative in my mind, which could be to offer a download to the redist installer, but never tested, whether PyWin32 will work with it.

@bdbaddog
Copy link

bdbaddog commented May 3, 2018 via email

@thopiekar
Copy link
Contributor Author

Well, it allows you to build c extensions, but the MFC libraries are still not included there.
Those Microsoft Foundation Classes are mainly ( recall if I'm wrong ) to create GUIs. Python comes with TK and thus only needs the visual c runtime. Therefore this package is shrinked to the bare minimum without MFC.

What we could maybe do is installing the redist package during build and add an option for setup.py to force it to look into a different location.

But don't know whether @mhammond agrees with this kind of hack || workaround.

@mhammond
Copy link
Owner

mhammond commented May 3, 2018

I'd be fine with having AppVeyor just perform a build and not bother trying to create the installation artifacts. I'd also be fine with a simple change to setup.py so it looks in another location, but I'd be less keen on having it download and install the redist package as part of the build process.

@thopiekar
Copy link
Contributor Author

Alright. There is good news from my side. I contacted the Appveyor people again and they said that you can take the redistributable libraries from the {WINDOWS_INSTALL}/Windows/WinSxS directory. I will try to find a way how to get them from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants