-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Adding AppVeyor CI (v2) #1187
Conversation
Second version, which includes all work I did before. It needs fixes and tweaks to some files, like setup.py. Additionally, it does no real tests at the moment and also does not use the latest SWIG to build the C extensions. However, at least something that is usable.
There is no such a file anymore. `setup.py` handles both now. Signed-off-by: Thomas Karl Pietrowski <thopiekar@gmail.com> (github: thopiekar)
|
As discussed in an issue report [1], I'm skipping the tests here. Therefore the only worrying issue is, how to fix the Python 2.7 builds. But, however, that is a different story. --------- [1] mhammond#1200
Great, thanks - I'll merge this and we can see what the fallout is :) |
No problem. The only thing, which won't work ever, are Python 2.7 builds. The main reason is that AppVeyor comes with Visual Studio 2008 Express, but only the Standard and Professional edition are providing the needed directory with the MFC90 libraries. I sent yesterday a mail to the AppVeyor team to ask whether it is possible to upgrade it or not. There is an alternative in my mind, which could be to offer a download to the redist installer, but never tested, whether PyWin32 will work with it. |
Would this package work?
https://www.microsoft.com/en-us/download/details.aspx?id=44266
…On Thu, May 3, 2018 at 3:52 AM, Thomas Karl Pietrowski < ***@***.***> wrote:
No problem. The only thing, which won't work ever, are Python 2.7 builds.
The main reason is that AppVeyor comes with Visual Studio 2008 Express, but
only the Standard and Professional edition are providing the needed
directory with the MFC90 libraries.
I sent yesterday a mail to the AppVeyor team to ask whether it is possible
to upgrade it or not.
There is an alternative in my mind, which could be to offer a download to
the redist installer, but never tested, whether PyWin32 will work with it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1187 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFBNMSQ84etTv_4E9LrFAwhALMU8_hMks5turdIgaJpZM4TAigF>
.
|
Well, it allows you to build c extensions, but the MFC libraries are still not included there. What we could maybe do is installing the redist package during build and add an option for setup.py to force it to look into a different location. But don't know whether @mhammond agrees with this kind of hack || workaround. |
I'd be fine with having AppVeyor just perform a build and not bother trying to create the installation artifacts. I'd also be fine with a simple change to setup.py so it looks in another location, but I'd be less keen on having it download and install the redist package as part of the build process. |
Alright. There is good news from my side. I contacted the Appveyor people again and they said that you can take the redistributable libraries from the {WINDOWS_INSTALL}/Windows/WinSxS directory. I will try to find a way how to get them from there. |
Second version, which includes all work I did before.
It needs fixes and tweaks to some files, like setup.py.
Additionally, it does no real tests at the moment and also does not use the latest SWIG to build the C extensions.
However, at least something that is usable.