Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visualizer.lua: improve compatiblity with other scripts #37

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

christoph-heinrich
Copy link
Contributor

@zaeboba can you please test if this works for you?

Writing to lavfi-complex even when no visualization is desired can cause
conflicts with other scripts, as can be seen in
mfcc64#36

Since each file needs to be evaluated individually if the visualizer
should be used for it. There is no benefit in keeping lavfi-complex set
across file boundaries and only adds the requirement that it has to be
reset if the next file shouldn't use the visualizer.
Setting lavfi-complex as a file-local-option avoids the need to reset it
via the script, and can help avoid conflicts with other scripts.

Additionally using the visualizer for files without audio doesn't make
sense, therefore the visualizer can be skipped for any files without
audio tracks.
@zaeboba
Copy link

zaeboba commented Sep 24, 2024

Yes, it works! Thank you!

@mfcc64 mfcc64 merged commit bff344e into mfcc64:master Sep 26, 2024
@christoph-heinrich christoph-heinrich deleted the skip_no_audio branch September 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants