Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add order field to item #2

Merged
merged 4 commits into from
Jul 1, 2023
Merged

Add order field to item #2

merged 4 commits into from
Jul 1, 2023

Conversation

FranCarrascosaMS
Copy link

@FranCarrascosaMS FranCarrascosaMS commented Jul 1, 2023 •
edited
Loading

Description

In this pull request, we'll add order field to items, so we can sort items based on an index. Moreover, we won't check vertical collisions when rendering items because we don't want to share lanes in previous items when there's an item in-between that collides.

Collision Example

Previous behavior

|-------------------------- TIMELINE -----------------------|
|------- 1 --------|               |-------- 3 ---------|
|---------------------------- 2 ----------------------------|

Current behavior

|-------------------------- TIMELINE -----------------------|
|------- 1 --------|
|---------------------------- 2 ----------------------------|
                                   |-------- 3 ---------|

@FranCarrascosaMS FranCarrascosaMS self-assigned this Jul 1, 2023
@FranCarrascosaMS FranCarrascosaMS merged commit 2a92b9a into master Jul 1, 2023
@FranCarrascosaMS FranCarrascosaMS deleted the fran/add-order-field-to-item branch July 1, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FranCarrascosaMS FranCarrascosaMS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FranCarrascosaMS