Add frame support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…frame-rate. TODO: minor-label rendering is not accurate in the library. Some frames are repeated, but we'll leave it as is for now because we're using our own formatter in the application part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, we'll add frame support, so we can use this library with time-codes at any frame-rate. Apart from that, we've exposed time-screen conversion methods to render elements on top of timeline accurately.
Out of Scope
Minor-label rendering has not been implemented precisely and some frames are repeated when scale is
frame. We'll leave it as is for now because we're using our own formatter in the application part.