fix(discovery): Do not fail if missing a subset of resources during API discover #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI discover Signed-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 49.55% 49.52% -0.04%
==========================================
Files 54 54
Lines 3295 3297 +2
==========================================
Hits 1633 1633
- Misses 1420 1422 +2
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AmitKumarDas
reviewed
Dec 6, 2021
AmitKumarDas
previously approved these changes
Dec 6, 2021
mikesmithgh
commented
Dec 6, 2021
mikesmithgh
force-pushed
the
ignore-missing-k8s-resources
branch
2 times, most recently
from
d025590 to
aadc1bb
Compare
Signed-off-by: Mike Smith <10135646+mjsmith1028@users.noreply.github.com>
grzesuav
approved these changes
Dec 6, 2021
|
Hi @grzesuav , would you be able to rerun the failing actions on this PR? I am able to run them successfully locally so I am not sure if there is just some flakiness going on or if my change would have any impact on the failiures. |
|
🎉 This PR is included in version 2.0.18 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to avoid completely failing API discovery if only a subset of resources fail to be fetched.
In my particular case, another team managing keda-operator-metrics-apiserver occasionally goes into a bad state causing an error discovery resources. If metacontroller is starting up for the first time, then it will get an error fetching resources and be blocked until the keda operator is in a good state and responds with resources during API discovery.
{"level":"error","ts":1638640761.0517867,"msg":"Failed to fetch discovery info","error":"unable to retrieve the complete list of server APIs: external.metrics.k8s.io/v1beta1: the server is currently unable to handle the request","stacktrace":"metacontroller/pkg/dynamic/discovery.(*ResourceMap).Start.func1\n\t/go/src/metacontroller/pkg/dynamic/discovery/discovery.go:179"}