Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSPF Track identifiers should be a list #140

Merged
merged 1 commit into from
May 28, 2024
Merged

JSPF Track identifiers should be a list #140

merged 1 commit into from
May 28, 2024

Conversation

amCap1712
Copy link
Member

See #115 for rationale.

@mayhem attempted to fix the issue in #138 again, but I got confused and reverted it, fixing it now.

@amCap1712
JSPF Track identifiers should be a list
2c41fa4 
See #115 for rationale.

@mayhem attempted to fix the issue in #138 again, but I got confused and
reverted it, fixing it now.
@amCap1712 amCap1712 requested a review from mayhem May 28, 2024 14:58
@github-actions GitHub Actions
Copy link

Test Results

  4 files  ±0    4 suites  ±0   4s ⏱️ ±0s
 50 tests ±0   50 ✅ ±0  0 💤 ±0  0 ❌ ±0 
200 runs  ±0  200 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2c41fa4. ± Comparison against base commit 9dc5882.

@github-actions GitHub Actions
Copy link

Package Line Rate Complexity Health
. 33% 0 ❌
content_resolver 0% 0 ❌
content_resolver.formats 6% 0 ❌
content_resolver.model 0% 0 ❌
external 39% 0 ❌
listenbrainz 46% 0 ❌
musicbrainz 71% 0 ➖
patches 25% 0 ❌
patches.lb_radio_classes 0% 0 ❌
tools 74% 0 ➖
. 33% 0 ❌
content_resolver 0% 0 ❌
content_resolver.formats 6% 0 ❌
content_resolver.model 0% 0 ❌
external 39% 0 ❌
listenbrainz 46% 0 ❌
musicbrainz 71% 0 ➖
patches 25% 0 ❌
patches.lb_radio_classes 0% 0 ❌
tools 74% 0 ➖
. 33% 0 ❌
content_resolver 0% 0 ❌
content_resolver.formats 6% 0 ❌
content_resolver.model 0% 0 ❌
external 39% 0 ❌
listenbrainz 46% 0 ❌
musicbrainz 71% 0 ➖
patches 25% 0 ❌
patches.lb_radio_classes 0% 0 ❌
tools 74% 0 ➖
. 33% 0 ❌
content_resolver 0% 0 ❌
content_resolver.formats 6% 0 ❌
content_resolver.model 0% 0 ❌
external 39% 0 ❌
listenbrainz 45% 0 ❌
musicbrainz 71% 0 ➖
patches 25% 0 ❌
patches.lb_radio_classes 0% 0 ❌
tools 74% 0 ➖
Summary 22% (4028 / 18084) 0 ❌

@amCap1712 amCap1712 merged commit 2b29c99 into main May 28, 2024
6 checks passed
@amCap1712 amCap1712 deleted the identifier-fix branch May 28, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayhem mayhem mayhem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amCap1712 @mayhem