LB-1395: Fix JSPF track identifier to be a list of strings #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the XSPF/JSPF spec [1] a track can have an arbitrary number of identifiers. For JSPF this means the "identifier" field must be a list [2]. [1] https://xspf.org/spec#4112141112-identifier [2] https://xspf.org/jspf
|
@mayhem @amCap1712 before I proceed here, can you verify that this format change is the proper thing to do? |
|
Indeed, well spotted. However we need to take care when releasing this PR -- we need to update listenbrainz-server as well, otherwise we'll get import failures if one if releases before the other. |
mayhem
approved these changes
Nov 14, 2023
|
All taken care of in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the XSPF/JSPF spec [1] a track can have an arbitrary number of identifiers. For JSPF this means the "identifier" field must be a list [2].
[1] https://xspf.org/spec#4112141112-identifier
[2] https://xspf.org/jspf
TODO: