Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inability to select breakout dimension before metric #50433

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix inability to select breakout dimension before metric #50433

merged 1 commit into from
Nov 26, 2024

Conversation

alxnddr
Copy link
Member

@alxnddr alxnddr commented Nov 23, 2024

Closes #49529

Description

Fixes viz settings sidebar crash when selecting second dimension before choosing any metrics.

How to verify

  • New > Question > Orders > Visualize
  • Change viz type to Bar
  • Open viz settings sidebar
  • Select X-axis dimension
  • Click "Add series breakout" and select select another dimension
  • Ensure it works

Checklist

  • Tests have been added/updated to cover changes in this PR

@alxnddr alxnddr added the no-backport Do not backport this PR to any branch label Nov 23, 2024
@alxnddr alxnddr self-assigned this Nov 23, 2024
@alxnddr alxnddr requested a review from kulyk November 23, 2024 02:45
@metabase-bot metabase-bot bot added the .Team/DashViz Dashboard and Viz team label Nov 23, 2024
@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 23, 2024 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@alxnddr alxnddr marked this pull request as draft November 25, 2024 15:07
@alxnddr alxnddr force-pushed the 49529-fix-inability-to-select-breakout-before-metric branch from 1946b51 to 91a70a4 Compare November 25, 2024 23:18
@alxnddr alxnddr marked this pull request as ready for review November 25, 2024 23:39
@alxnddr alxnddr merged commit 948bd56 into master Nov 26, 2024
261 of 262 checks passed
@alxnddr alxnddr deleted the 49529-fix-inability-to-select-breakout-before-metric branch November 26, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulyk kulyk kulyk approved these changes

Assignees

@alxnddr alxnddr

Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Row visualization settings sidebar crashes
2 participants
@alxnddr @kulyk