SDK launch in core app #48107
Merged
SDK launch in core app #48107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP code * use svg illustrations instead of png-in-svg * public embed ui * fix unit tests * more unit tests fixes * e2e updates * fix a bunch of tests by updating a helper * update other tests * update other tests * update more tests * test * unskip test and mock clipboardData to avoid window.prompt pausing the test * hopefully the last test i have to update * something something removing empty beforeEach * cleanup while doing self review * update unit test * move public embed card to its own file * styled -> css modules * wip copy * remove unused lint rule * update copy * fix: close popover when clicking outside of it * remove "seamless" and use only "PRO" in the badge * fix padding of public embed card popover
|
@oisincoveney You have modified embedding SDK code. Please make sure the PR title follows Conventional Commits style.
These types Please also make sure to include For example, these are valid PR titles:
|
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 7249587...de357c7.
|
rafpaf
added a commit
that referenced
this pull request
Oct 11, 2024
Co-authored-by: Oisin Coveney <oisin@metabase.com> Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by: bryan <bryan.maass@gmail.com> Co-authored-by: Nicolò Pretto <info@npretto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will contain the changes that we want to merge into the main app when we launch the SDK.
Some of the projects/prs