Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak some sheet around CSV uploads #48000

Merged
merged 9 commits into from
Sep 20, 2024
Merged

Tweak some sheet around CSV uploads #48000

merged 9 commits into from
Sep 20, 2024

Conversation

crisptrutski
Copy link
Contributor

@crisptrutski crisptrutski commented Sep 18, 2024 •
edited
Loading

  • Add support for google sheets exported date format.
  • Return the newly created table id corresponding to a CSV upload.
  • Fix Serialization flakes.
  • Parse serialized dates in minimal search implementation.

@metabase-bot metabase-bot bot added the .Team/BackendComponents also known as BEC label Sep 18, 2024
@crisptrutski crisptrutski added the PR-Env Create PR Env https://www.notion.so/metabase/Ephemeral-PR-Environments-c74a3710c87a460dbf4fc0007a001 label Sep 18, 2024
@crisptrutski crisptrutski added the no-backport Do not backport this PR to any branch label Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Deploying a preview environment for commit f557b5e.
✅ Preview:
https://pr48000.coredev.metabase.com
🗒️ login instructions

@piranha piranha removed the PR-Env Create PR Env https://www.notion.so/metabase/Ephemeral-PR-Environments-c74a3710c87a460dbf4fc0007a001 label Sep 19, 2024
crisptrutski
crisptrutski commented Sep 20, 2024
View reviewed changes
enterprise/backend/test/metabase_enterprise/serialization/api_test.clj
@@ -181,7 +181,7 @@
"secrets" false
"success" true
"error_message" nil}
(-> (snowplow-test/pop-event-data-and-user-id!) first :data))))
(-> (snowplow-test/pop-event-data-and-user-id!) last :data))))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for serialization test flakes.

enterprise/backend/test/metabase_enterprise/serialization/api_test.clj
Comment on lines -225 to -226
(is (= #{"Card" "Database" "Collection"}
(log-types (str/split-lines log))))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is non-deterministic whether the Dashboard gets serialized before the Collection fails.

@crisptrutski crisptrutski enabled auto-merge (squash) September 20, 2024 11:02
@nemanjaglumac nemanjaglumac mentioned this pull request Sep 20, 2024
Closed
@nemanjaglumac nemanjaglumac added backport Automatically create PR on current release branch on merge and removed no-backport Do not backport this PR to any branch labels Sep 20, 2024
@nemanjaglumac nemanjaglumac merged commit 48aad35 into master Sep 20, 2024
140 of 148 checks passed
@nemanjaglumac nemanjaglumac deleted the sheetstorm branch September 20, 2024 13:15
@github-automation-metabase github-automation-metabase mentioned this pull request Sep 20, 2024
Merged
crisptrutski added a commit that referenced this pull request Sep 20, 2024
@crisptrutski @piranha
Tweak some sheet around CSV uploads (#48000)
3e4ec56 
Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
lbrdnk added a commit that referenced this pull request Sep 21, 2024
@lbrdnk
Revert "Tweak some sheet around CSV uploads (#48000)"
c1d6bc9 
This reverts commit 48aad35.
crisptrutski added a commit that referenced this pull request Sep 24, 2024
@crisptrutski @piranha
Tweak some sheet around CSV uploads (#48000)
32fcff9 
Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
crisptrutski added a commit that referenced this pull request Sep 24, 2024
@crisptrutski @piranha
Tweak some sheet around CSV uploads (#48000)
28bdfac 
Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
qnkhuat pushed a commit that referenced this pull request Sep 24, 2024
@github-automation-metabase @crisptrutski @piranha
Tweak some sheet around CSV uploads (#48000) (#48042)
fd5cc53 
Co-authored-by: Chris Truter <chris@metabase.com>
Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
@github-actions github-actions bot added this to the 0.50.27 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piranha piranha piranha approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

@crisptrutski crisptrutski

Labels
backport Automatically create PR on current release branch on merge .Team/BackendComponents also known as BEC
Projects
None yet
Milestone
0.50.27
Development

Successfully merging this pull request may close these issues.
3 participants
@crisptrutski @piranha @nemanjaglumac