rename event -> simple_event and trackEvent -> trackSimpleEvent #47608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npretto
added
the
backport
npretto
commented
Sep 4, 2024
| "description": "Generic event to track interactions and actions that happen within Metabase. This should be used as a default schema for tracking events. If more specific context is needed, we can use custom context entities (https://docs.snowplow.io/docs/understanding-your-pipeline/entities/).", | ||
| "self": { | ||
| "vendor": "com.metabase", | ||
| "name": "simple_event", |
There was a problem hiding this comment.
this line is the only thing I changed, weird git didn't understood i was a rename
There was a problem hiding this comment.
Might be because you changed it in one go and not with 2 commits or something.
Somtom
approved these changes
Sep 4, 2024
snowplow/iglu-client-embedded/schemas/com.metabase/simple_event/jsonschema/1-0-0
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Schmidt <thomas@metabase.com>
ranquild
approved these changes
Sep 4, 2024
github-automation-metabase
pushed a commit
that referenced
this pull request
Sep 4, 2024
* rename event -> simple_event and trackEvent -> trackSimpleEvent * add empty line at the end of the file Co-authored-by: Thomas Schmidt <thomas@metabase.com> --------- Co-authored-by: Thomas Schmidt <thomas@metabase.com>
github-automation-metabase
added a commit
that referenced
this pull request
Sep 4, 2024
…) (#47625) * rename event -> simple_event and trackEvent -> trackSimpleEvent * add empty line at the end of the file --------- Co-authored-by: Nicolò Pretto <info@npretto.com> Co-authored-by: Thomas Schmidt <thomas@metabase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This renames
eventto simple event to make it clear that it's a specific schema for simple events, not a base event that all the others "inherit"/extend.Briefly discussed here: https://metaboat.slack.com/archives/C01MS7DQKR6/p1725022707669739?thread_ts=1724940664.655259&cid=C01MS7DQKR6