Add an API to get stale dashboards and cards #44711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnswanson
changed the title
|
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff cc6ac53...508e819.
|
johnswanson
force-pushed
the
add-dashboard-last-viewed-at
branch
from
cc6ac53 to
ec048b7
Compare
johnswanson
changed the title
johnswanson
force-pushed
the
add-dashboard-last-viewed-at
branch
from
ec048b7 to
df9d374
Compare
johnswanson
force-pushed
the
add-dashboard-last-viewed-at
branch
from
df9d374 to
79c58e2
Compare
johnswanson
force-pushed
the
add-dashboard-last-viewed-at
branch
from
79c58e2 to
614cc46
Compare
johnswanson
force-pushed
the
add-dashboard-last-viewed-at
branch
from
642367f to
60d9d8d
Compare
johnswanson
force-pushed
the
add-dashboard-last-viewed-at
branch
2 times, most recently
from
0a718a4 to
07f058e
Compare
johnswanson
force-pushed
the
add-dashboard-last-viewed-at
branch
from
07f058e to
77bf1e8
Compare
johnswanson
force-pushed
the
add-stale
branch
2 times, most recently
from
ca7efbe to
5455d9c
Compare
For e2e tests, we need a way to mark a card or dashboard as stale. I think the easiest way to do this is to just create a testing endpoint that we can call to update the `last_used_at` or `last_viewed_at` of the card/dashboard to set it to ~7 months ago.
I forgot to commit this before. Tests seem to be failing due to [this](#45848)
johnswanson
force-pushed
the
add-stale
branch
7 times, most recently
from
4d6a805 to
03dae7f
Compare
noahmoss
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
metabase.stalemodule, which has one publicfunction (so far):
metabase.stale/find-candidates. This takes a set ofcollection-ids, a cutoff date, and pagination/sort info.Next, we'll write an HTTP API endpoint that will figure out the appropriate
set of
collection-idsfor a given user/request, call this function,and return the results in the shape we want.