Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove database prompt banner #40648

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Remove database prompt banner #40648

merged 10 commits into from
Mar 27, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented Mar 26, 2024

Closes #40644

@rafpaf rafpaf self-assigned this Mar 26, 2024
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Mar 26, 2024
@rafpaf rafpaf marked this pull request as ready for review March 26, 2024 20:35
@rafpaf rafpaf marked this pull request as draft March 26, 2024 20:35
@rafpaf rafpaf added the no-backport Do not backport this PR to any branch label Mar 26, 2024
@rafpaf rafpaf marked this pull request as ready for review March 26, 2024 20:37
@rafpaf rafpaf requested a review from a team March 26, 2024 20:38
@rafpaf rafpaf marked this pull request as draft March 26, 2024 20:39
@rafpaf rafpaf marked this pull request as ready for review March 27, 2024 01:26
@replay-io replay.io
Copy link

replay-io bot commented Mar 27, 2024 •
edited
Loading

Status Complete ↗︎
Commit 1e5d4ab
Results
⚠️ 7 Flaky
✅ 2376 Passed

npfitz
npfitz requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@npfitz npfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the snowplow schema, it looks good!

@rafpaf rafpaf requested a review from npfitz March 27, 2024 13:42
@rafpaf rafpaf merged commit b426fe7 into master Mar 27, 2024
107 checks passed
@rafpaf rafpaf deleted the remove-database-prompt-banner branch March 27, 2024 17:51
oisincoveney pushed a commit that referenced this pull request Mar 28, 2024
@rafpaf @oisincoveney
Remove database prompt banner (#40648)
ae45b72
@iethree iethree added backport Automatically create PR on current release branch on merge and removed no-backport Do not backport this PR to any branch labels Apr 1, 2024
@metabase-bot metabase-bot bot mentioned this pull request Apr 1, 2024
Merged
rafpaf added a commit that referenced this pull request Apr 1, 2024
@rafpaf
Remove database prompt banner (#40648)
697cf2c
rafpaf added a commit that referenced this pull request Apr 1, 2024
@metabase-bot @rafpaf
🤖 backported "Remove database prompt banner" (#40872)
2e39abd 
* Remove database prompt banner (#40648)

* Remove location prop from AppBanner

---------

Co-authored-by: Raphael Krut-Landau <raphael.kl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npfitz npfitz npfitz approved these changes

Assignees

@rafpaf rafpaf

Labels
backport Automatically create PR on current release branch on merge .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of database connection help banner
3 participants
@rafpaf @npfitz @iethree