Codespaces devcontainer #7039

sivanaikk · 2023-02-09T05:57:17Z

Notes for Reviewers

This PR fixes #5904

Yes, I signed my commits.

welcome · 2023-02-09T05:57:19Z

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

leecalcote · 2023-02-15T00:02:44Z

Thanks for this, @sivanaikk 👍

acald-creator · 2023-02-15T15:20:26Z

Reviewing, as I was researching this to see if we could use devcontainers to ease contributor onboarding the projects.

rav121 · 2023-02-15T15:58:45Z

There is UI integration test that is failing, us of syntax error in indexui_spec.js.
However, I don't think this changes are related to the tests run.

leecalcote · 2023-02-15T22:00:03Z

Syncing with master to re-run with passing indexui_spec.js.

leecalcote · 2023-02-16T13:02:18Z

.devcontainer/server/Dockerfile

+ARG NODE_VERSION="none"
+RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi
+RUN go install golang.org/dl/go1.19.1@latest \
+&& go1.19.1 download 


Thanks for giving this a review, @Azanul

Good feedback for @sivanaikk’s consideration.

@sivanaikk what do you think?

Previously we were using go1.19.1 in Makefile. Have to update Dockerfile

I don't think that there is some sagnificant difference between go1.19.1 and go1.19
https://github.com/devcontainers/templates/tree/main/src/go

Signed-off-by: Kethavath Siva Naik <60335740+sivanaikk@users.noreply.github.com>

Chadha93 · 2023-02-21T17:17:01Z

@sivanaikk Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

sivanaikk · 2023-02-22T07:26:41Z

@sivanaikk Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

Just added it to the Meeting agenda. Thank you 🙌

AugustasV · 2023-03-14T19:02:37Z

.devcontainer/server/Dockerfile

+ARG NODE_VERSION="none"
+RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi
+RUN go install golang.org/dl/go1.19.1@latest \
+&& go1.19.1 download 


I don't think that there is some sagnificant difference between go1.19.1 and go1.19
https://github.com/devcontainers/templates/tree/main/src/go

AugustasV · 2023-03-14T19:13:20Z

.devcontainer/server/base.Dockerfile

+    && . /etc/os-release \
+    && if [ "${VERSION_CODENAME}" = "bullseye" ]; then apt-get -y install --no-install-recommends python-is-python3; fi \
+    # Clean up
+    && apt-get autoremove -y && apt-get clean -y && rm -rf /var/lib/apt/lists/* /root/.gnupg /tmp/library-scripts


-q argument could be used

AugustasV · 2023-03-14T19:13:26Z

.devcontainer/server/base.Dockerfile

+# RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
+
+# [Optional] Uncomment if you want to install more global node modules
+# RUN su node -c "npm install -g <your-package-list-here>""


AugustasV · 2023-03-14T19:19:45Z

.devcontainer/ui/base.Dockerfile

+# RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
+
+# [Optional] Uncomment if you want to install more global node modules
+# RUN su node -c "npm install -g <your-package-list-here>""


AugustasV · 2023-03-14T20:01:34Z

server/.devcontainer/base.Dockerfile

+# RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
+
+# [Optional] Uncomment if you want to install more global node modules
+# RUN su node -c "npm install -g <your-package-list-here>""


AugustasV · 2023-03-14T20:01:48Z

ui/.devcontainer/base.Dockerfile

+# RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
+
+# [Optional] Uncomment if you want to install more global node modules
+# RUN su node -c "npm install -g <your-package-list-here>""


Chadha93 · 2023-03-15T10:09:49Z

@sivanaikk Let's discuss this on the Meshery Dev call. Please add this as an agenda item in the meeting minutes if you would. :)

stale · 2023-04-24T13:15:17Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote added the area/devops label Feb 15, 2023

leecalcote requested review from a team, leecalcote, sunkuranganath and acald-creator and removed request for a team, leecalcote, sunkuranganath and acald-creator February 15, 2023 00:03

acald-creator force-pushed the codespaces-devcontainer branch from bc7767c to 02a5bc9 Compare February 15, 2023 15:19

Azanul reviewed Feb 16, 2023

View reviewed changes

sivanaikk added 2 commits February 16, 2023 12:34

Feature: Added Codespace Configuration

4fe3cbf

Signed-off-by: Kethavath Siva Naik <60335740+sivanaikk@users.noreply.github.com>

Changed the path of devcontainers

a7ff87d

Signed-off-by: Kethavath Siva Naik <60335740+sivanaikk@users.noreply.github.com>

acald-creator force-pushed the codespaces-devcontainer branch from 448f4f8 to a7ff87d Compare February 16, 2023 18:34

Merge branch 'meshery:master' into codespaces-devcontainer

59fe799

AugustasV reviewed Mar 14, 2023

View reviewed changes

stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 24, 2023

This comment was marked as outdated.

Sign in to view

stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Apr 24, 2023

This comment was marked as outdated.

Sign in to view

Azanul closed this May 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Codespaces devcontainer #7039

Codespaces devcontainer #7039

sivanaikk commented Feb 9, 2023 •

edited

Loading

welcome bot commented Feb 9, 2023

leecalcote commented Feb 15, 2023

acald-creator commented Feb 15, 2023

rav121 commented Feb 15, 2023

leecalcote commented Feb 15, 2023

This comment was marked as outdated.

leecalcote Feb 16, 2023 •

edited

Loading

leecalcote Feb 16, 2023

leecalcote Feb 19, 2023

sivanaikk Feb 20, 2023

AugustasV Mar 14, 2023

Chadha93 commented Feb 21, 2023

sivanaikk commented Feb 22, 2023

AugustasV Mar 14, 2023

AugustasV Mar 14, 2023

AugustasV Mar 14, 2023

AugustasV Mar 14, 2023

AugustasV Mar 14, 2023

AugustasV Mar 14, 2023

Chadha93 commented Mar 15, 2023

stale bot commented Apr 24, 2023

This comment was marked as outdated.

This comment was marked as outdated.

Codespaces devcontainer #7039

Codespaces devcontainer #7039

Conversation

sivanaikk commented Feb 9, 2023 • edited Loading

welcome bot commented Feb 9, 2023

leecalcote commented Feb 15, 2023

acald-creator commented Feb 15, 2023

rav121 commented Feb 15, 2023

leecalcote commented Feb 15, 2023

This comment was marked as outdated.

leecalcote Feb 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chadha93 commented Feb 21, 2023

sivanaikk commented Feb 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chadha93 commented Mar 15, 2023

stale bot commented Apr 24, 2023

This comment was marked as outdated.

This comment was marked as outdated.

sivanaikk commented Feb 9, 2023 •

edited

Loading

leecalcote Feb 16, 2023 •

edited

Loading