Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing golangci-lint #13142

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fixing golangci-lint #13142

merged 3 commits into from
Jan 3, 2025

Conversation

devhindo
Copy link
Member

@devhindo devhindo commented Jan 3, 2025

No description provided.

@devhindo
Bump golangci-lint version to v1.63 in CI workflows
154d7f1 
Signed-off-by: devhindo <lildevhind@gmail.com>
@github-actions github-actions bot added the area/ci Continuous Integration label Jan 3, 2025
@devhindo
Remove unnecessary blank line in default_local_provider.go
adf5e78 
Signed-off-by: devhindo <lildevhind@gmail.com>
@devhindo
Remove unnecessary blank line in default_local_provider.go
5df23ca 
Signed-off-by: devhindo <lildevhind@gmail.com>
Yashsharma1911
Yashsharma1911 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@Yashsharma1911 Yashsharma1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yashsharma1911 Yashsharma1911 merged commit 1f3c92a into meshery:master Jan 3, 2025
4 of 5 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

END-TO-END TESTS

  • Testing started at: January 3rd 2025, 1:19:05 pm

📦 Test Result Summary

  • ✅ 29 passed
  • ❌ 2 failed
  • ⚠️ 9 flaked
  • ⏩ 0 skipped

⌛ Duration: 8 minutes and 17 seconds

Overall Result: 👎 Some tests failed.

[Show/Hide] Test Result Details
Test Browser Test Case Tags Result
1 chromium-meshery-provider Compare test of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
2 chromium-meshery-provider Delete a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
3 chromium-meshery-provider Connect to Meshery Istio Adapter and configure it ❌
4 chromium-local-provider Add a cluster connection by uploading kubeconfig file unstable ⚠️
5 chromium-local-provider Transition to disconnected state and then back to connected state unstable ⚠️
6 chromium-local-provider Transition to ignored state and then back to connected state unstable ⚠️
7 chromium-local-provider Transition to not found state and then back to connected state unstable ⚠️
8 chromium-local-provider Delete Kubernetes cluster connections unstable ⚠️
9 chromium-local-provider View detailed result of a performance profile (Graph Visualiser) with load generator "fortio" and service mesh "None" unstable ⚠️
10 chromium-local-provider Edit the configuration of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
11 chromium-local-provider Compare test of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
12 chromium-local-provider Delete a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
13 chromium-local-provider Connect to Meshery Istio Adapter and configure it ❌
14 chromium-local-provider Toggle "Send Anonymous Usage Statistics" unstable ⚠️
15 chromium-local-provider Toggle "Send Anonymous Performance Results" unstable ⚠️

@lekaf974
Copy link
Contributor

lekaf974 commented Jan 3, 2025

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yashsharma1911 Yashsharma1911 Yashsharma1911 approved these changes

Assignees
No one assigned
Labels
area/ci Continuous Integration component/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devhindo @lekaf974 @Yashsharma1911