-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mesheryctl] mesheryctl system config minikube command workflow #12704
Comments
This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.
|
Can I work on this? |
Hi @Alero-Awani @leecalcote , could you please have a look that is this(updated) approach correct?
OR
|
@yaten2302 something not described in the issue is that |
@lekaf974 , I've a doubt that, if we follow the previous workflow (i.e. separate start and config commands), and then try to start meshery with docker, then will it also create issues, or will it work? Because, while integrating these 2 commands, I didn't change any func. |
See mesheryctl Command Tracker for current status of commands.
Current Behavior
The
mesheryctl system config minikube
command has usability issues due to its workflow and dependencies.mesheryctl system login
before running the command. This sequence is not straightforward and can confuse new users.The current required workflow involves:
mesheryctl system start
.mesheryctl system login
.mesheryctl system config minikube
command to:Desired Behavior
The mesheryctl system config minikube command might need to be deprecated and its core functionality integrated into
mesheryctl system start
to simplify the user workflow. Specifically:The kubeconfig file should be automatically minified, flattened, and uploaded to the Meshery server as part of the initialization process during
mesheryctl system start.
This change will eliminate the need for users to run a separate command for kubeconfig processing and uploading.
Implementation
Assess Command Relevance: Determine if there is a compelling reason to keep the mesheryctl system config minikube command (e.g edge cases, advanced workflows).
Integrate Functionality:
mesheryctl system start
command.Code Reference
Mesheryctl system config code
Contributor Resources
The text was updated successfully, but these errors were encountered: